Skip to content

Fix Markdown checks#673

Merged
reyang merged 7 commits intoopen-telemetry:mainfrom
fandreuz:fix-md-checks
Jun 23, 2025
Merged

Fix Markdown checks#673
reyang merged 7 commits intoopen-telemetry:mainfrom
fandreuz:fix-md-checks

Conversation

@fandreuz
Copy link
Copy Markdown
Contributor

@fandreuz fandreuz commented Jun 13, 2025 •
edited
Loading 

[...]
CHANGELOG.md:253 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Removed"]
CHANGELOG.md:262 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Added"]
CHANGELOG.md:272 MD024/no-duplicate-heading Multiple headings with the same content [Context: "Maturity"]
[...]
  • Disable MD059, the transgressions I see don't look that bad to me:
CONTRIBUTING.md:27:176 MD059/descriptive-link-text Link text should be descriptive [Context: "[here]"]

View meeting notes of previous SIG calls in this [google doc](https://docs.google.com/spreadsheets/d/1SYKfjYhZdm2Wh2Cl6KVQalKg_m4NhTPZqq-8SzEVO6s/edit?gid=0#gid=0) 
as stated [here](https://github.com/open-telemetry/community/?tab=readme-ov-file#governing-bodies) to stay up to date.

@fandreuz fandreuz requested a review from a team June 13, 2025 23:28
@fandreuz fandreuz mentioned this pull request Jun 13, 2025
Merged
@reyang
Copy link
Copy Markdown
Member

reyang commented Jun 13, 2025

Thanks @fandreuz! I see the package.json and package-lock.json being deleted in the PR, is this intentional?

@fandreuz
Copy link
Copy Markdown
Contributor Author

fandreuz commented Jun 14, 2025

Thanks @fandreuz! I see the package.json and package-lock.json being deleted in the PR, is this intentional?

Hi @reyang, that's intentional because the npm dependencies are now embedded in a Docker container rather than being installed on the host. Let me know if that's a problem.

@arminru arminru requested a review from a team June 17, 2025 10:58
MrAlias
MrAlias reviewed Jun 17, 2025
View reviewed changes
Comment thread Makefile Outdated
Comment thread Makefile Outdated
Comment thread .markdownlint.yaml
@fandreuz
Copy link
Copy Markdown
Contributor Author

fandreuz commented Jun 23, 2025

Hi @MrAlias, can this be merged?

@MrAlias
Copy link
Copy Markdown
Contributor

MrAlias commented Jun 23, 2025

Hi @MrAlias, can this be merged?

I looks ready to merge to me, but I am not authorized to merge this.

@reyang reyang merged commit 189b264 into open-telemetry:main Jun 23, 2025
15 checks passed
@reyang reyang mentioned this pull request Jul 11, 2025
Closed
@chalin chalin mentioned this pull request Sep 11, 2025
Closed
@RajaVarmaGVSSR RajaVarmaGVSSR mentioned this pull request Oct 1, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrAlias MrAlias MrAlias approved these changes

@arminru arminru arminru approved these changes

@reyang reyang reyang approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fandreuz @reyang @MrAlias @arminru